This revision was automatically updated to reflect the committed changes. Closed by commit rHG058497a2cc36: dirstate: add a comment on why we don't need to check if something is a dir/file (authored by spectral, committed by ).
REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4161?vs=10081&id=10087 REVISION DETAIL https://phab.mercurial-scm.org/D4161 AFFECTED FILES mercurial/dirstate.py CHANGE DETAILS diff --git a/mercurial/dirstate.py b/mercurial/dirstate.py --- a/mercurial/dirstate.py +++ b/mercurial/dirstate.py @@ -912,6 +912,11 @@ continue raise for f, kind, st in entries: + # If we needed to inspect any files, visitentries would have + # been 'this' or 'all', and we would have set it to None + # above. If we have visitentries populated here, we don't + # care about any files in this directory, so no need to + # check the type of `f`. if visitentries and f not in visitentries: continue if normalizefile: To: spectral, #hg-reviewers, martinvonz Cc: mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
