av6 added a comment.
I've commented on things that can be improved, but they shouldn't stop this from landing. INLINE COMMENTS > relnotes:51 > + r": implement ": -5, > + r"2\.4": -20, > + r": use .* implementation": -20, I assume it's for Python 2.4. Maybe needs more versions we don't support anymore? > relnotes:57-58 > + # dumb keywords > + r"\S+/\S+:": -10, > + r"\S+/\S+:": -10, > + r"\S+\.\S+:": -10, These look the same. > relnotes:82 > + (r"phases|status|summary|amend|tag|help|verify", "commands"), > + (r"rebase|mq|color|pager|convert|eol|histedit|largefiles", "extensions"), > + (r"shelve|unshelve", "extensions"), `color` is not an extension anymore. `pager` is still an extension, but also exists in core. > relnotes:88-97 > + ap.add_argument( > + "startrev", > + metavar="REV", > + type=str, > + nargs=1, > + help=( > + "Starting revision for the release notes. This revision " Nit: this block looks too mundane to take 10 lines. The one below is even longer. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4291 To: durin42, #hg-reviewers Cc: av6, mjpieters, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
