yuja added a comment.
> def read(repo): > try: > f = repo.cachevfs(_filename(repo)) > > - lines = f.read().split('\n') > - f.close() > - except (IOError, OSError): > - return None - > - try: > - cachekey = lines.pop(0).split(" ", 2) + cachekey = next(f).split(" ", 2) Several tests fail, probably because of missed rstrip(). > partial.setdefault(label, []).append(node) > if state == 'c': > partial._closednodes.add(node) > > + > + except (IOError, OSError): > + return None > + > > except Exception as inst: > if repo.ui.debugflag: > msg = 'invalid branchheads cache' Missed `finally: f.close()`? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4281 To: mjpieters, #hg-reviewers, durin42 Cc: yuja, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel