av6 added inline comments. INLINE COMMENTS
> spectral wrote in zsh_completion:1272 > Mine has a --cleanup flag. Not sure where that came from, and I think it's > dangerous as heck and I don't like it, but ... should we list it? (I'm 100% > fine with the answer being "no, it's too scary" :)) I don't think it's too scary, but I do think it's too stealthy. > spectral wrote in zsh_completion:1277 > Optional: should we make --delete exclusive with anything else? what about > --list, patch, stat..? I gave up on that idea. The logic in hgext.shelve.shelvecmd() is more or less clear, but translated into zsh completions it takes too much space: it would mean that many flags would mention almost every other flag, and --cleanup would mention literally all of them. But not global flags, mind, so you can't shortcut with `(-)`. I'd like to see some clever way to translate `allowables` and the related code into zsh instead, but I myself can't write that kind of zsh yet. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4428 To: av6, #hg-reviewers Cc: spectral, mercurial-devel _______________________________________________ Mercurial-devel mailing list [email protected] https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
