martinvonz requested changes to this revision. martinvonz added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > sparse.py:365 > + if branchmerge: > + if args and len(args) == 5: > + f1, f2, fa, move, anc = args This seems both cryptic and brittle. Can we instead do something like this? if type in (merge.ACTION_MOVE, merge.ACTION_...): f1, f2, fa, move, anc = args REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4341 To: pulkit, #hg-reviewers, martinvonz Cc: martinvonz, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel