pulkit added inline comments.

INLINE COMMENTS

> martinvonz wrote in repository.py:22-24
> I'm not sure I understand what this says.
> 
> The first sentence sounds too obvious to mention (kind of like "when it's 
> done, it should be working well"), but I suspect you mean something else. Do 
> you mean that that's the criteria for dropping the "exp-" prefix (much like 
> the comment for narrow says above)?
> 
> I don't know what the second sentence says either. Isn't it already 
> generalized to shallow and ellipses?

Yeah, the intent was to say the same thing as the comment about 
NARROW_REQUIREMENT says but re-reading myself, looks like I messed up. I will 
update this.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4810

To: pulkit, #hg-reviewers
Cc: martinvonz, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to