martinvonz added a comment.

  > This is BC because new clients won't be able to extend from old 
narrow-enabled servers.
  
  I think your previous patch was also BC in that sense since it started 
requiring the server to have the ellipses wire capability when widening with 
ellipsis nodes. It's not a problem for us to add that capability (we already 
have), but you may want to mention it there for consistency :), if I understood 
that right.

INLINE COMMENTS

> narrowcommands.py:137
>      if wireprotoserver.NARROWCAP not in pullop.remote.capabilities():
>          raise error.Abort(_("server doesn't support narrow clones"))
>      orig(pullop, kwargs)

Change "doesn't" to "does not" here too so it's consistent?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4789

To: pulkit, durin42, #hg-reviewers
Cc: martinvonz, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to