pulkit added a comment.
In https://phab.mercurial-scm.org/D4813#73534, @martinvonz wrote: > > I need to specify the arguments instead of just specifying "*". > > Don't forget this one. Did that! INLINE COMMENTS > indygreg wrote in narrowbundle2.py:329 > Because of how `wireprotov1server.getbundle()` handles arguments, removing > this argument from the definition of arguments to the `getbundle` wire > protocol command means that existing clients attempting to send the argument > to the `getbundle` wire protocol command will cause a server-side exception. > > We need to keep this key around for BC unless we're fine breaking old clients > or unless there is something that changes server capabilities in a way that > prevents old clients from calling `getbundle` with this argument. We could > ignore the argument or nerf the server to error if it is received. This argument has not yet been a part of release. It was introduced in https://phab.mercurial-scm.org/D4383 which was pushed in the end on August. So I don't think we need to take care of that unless someone is using hg from default branch. @martinvonz will this removal affect you? Do you have https://phab.mercurial-scm.org/D4383 grafted to your internal mercurial? > martinvonz wrote in narrowwirepeer.py:49 > It seems to depend only on `widen_bundle`, which doesn't seem to depend on > anything else, so it would probably be easy to move it to core, but I won't > insist. I will try to follow-up before the freeze. > indygreg wrote in narrowwirepeer.py:79-82 > We probably want to extract the argument "parsing" from > `wireprotov1server.getbundle()` into a standalone function so we can use it > for this command. > > Arguments in wire protocol version 1 are wonky :/ Maybe we need to have a function which takes the values and what type to decode into and that can be used in both places. Also after specifying the args names instead of "*", we don't have a dictionary with all the arguments. We need to build one. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4813 To: pulkit, durin42, #hg-reviewers, martinvonz Cc: indygreg, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
