On 25/10/2018 13:24, Yuya Nishihara wrote: > On Fri, 19 Oct 2018 14:25:13 +0200, Boris Feld wrote: >> # HG changeset patch >> # User Boris Feld <boris.f...@octobus.net> >> # Date 1538556809 -7200 >> # Wed Oct 03 10:53:29 2018 +0200 >> # Node ID 78ffc55c0d6034972ea3d49b8c565c563ef27121 >> # Parent 824b687ff6af49622a18dfea760cf41a7abe5aa7 >> # EXP-Topic revlog-perf >> # Available At https://bitbucket.org/octobus/mercurial-devel/ >> # hg pull https://bitbucket.org/octobus/mercurial-devel/ -r >> 78ffc55c0d60 >> perf: introduce a perfrevlogwrite command > Looks generally good. > >> +@command(b'perfrevlogwrite', revlogopts + formatteropts + >> + [(b's', b'startrev', 1000, b'revision to start writing at'), >> + (b'', b'stoprev', -1, b'last revision to write'), >> + (b'', b'count', 3, b'last revision to write'), >> + ], >> + b'-c|-m|FILE') >> +def perfrevlogwrite(ui, repo, file_=None, startrev=0, stoprev=-1, **opts): > Which is the default startrev value? 1000 or 0?
The default is 1000, we should update the function default value. We will send a V3, with an explicit class declaration. _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
