D5235: revlog: replace PyInt_AS_LONG with a more portable helper function

[yuja (Yuya Nishihara)]

yuja added a comment.


  > @@ -464,7 +470,9 @@
  > 
  >             if (iter == NULL)
  >                     return -2;
  >             while ((iter_item = PyIter_Next(iter))) {
  > 
  > - iter_item_long = PyInt_AS_LONG(iter_item); +                      if 
(!pylong_to_long(iter_item, &iter_item_long)) { +                            
return -1;
  
  `Py_DECREF(iter_item)` and `return -2`.
  
  I didn't notice it last time, sorry.
  
  > +                   }
  > 
  >                     Py_DECREF(iter_item);
  >                     if (iter_item_long < min_idx)
  >                             min_idx = iter_item_long;

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5235

To: durin42, #hg-reviewers
Cc: yuja, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel