pulkit added a comment.
In https://phab.mercurial-scm.org/D5308#78985, @yuja wrote: > > - a/mercurial/store.py +++ b/mercurial/store.py @@ -486,7 +486,7 @@ if self.addls: > > 1. if we have just new entries, let's append them to the fncache tr.addbackup('fncache') > > - fp = self.vfs('fncache', mode='ab', atomictemp=True) + fp = self.vfs('fncache', mode='ab') > > Ah, no. addbackup() creates hardlink, which means fncache can't be updated in > place. Also, the reader wouldn't handle partially-written fncache well. do we need to call `addbackup()` if we are just appending? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5308 To: pulkit, #hg-reviewers Cc: yuja, mjpieters, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel