gracinet created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers.
REVISION SUMMARY It was confusing to have p1 and parents.1 ; (p1, p2) is clearer. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D5365 AFFECTED FILES rust/hg-core/src/ancestors.rs CHANGE DETAILS diff --git a/rust/hg-core/src/ancestors.rs b/rust/hg-core/src/ancestors.rs --- a/rust/hg-core/src/ancestors.rs +++ b/rust/hg-core/src/ancestors.rs @@ -126,19 +126,18 @@ } Some(c) => *c, }; - let parents = self + let (p1, p2) = self .graph .parents(current) .unwrap_or((NULL_REVISION, NULL_REVISION)); - let p1 = parents.0; if p1 < self.stoprev || self.seen.contains(&p1) { self.visit.pop(); } else { *(self.visit.peek_mut().unwrap()) = p1; self.seen.insert(p1); }; - self.conditionally_push_rev(parents.1); + self.conditionally_push_rev(p2); Some(current) } } To: gracinet, #hg-reviewers Cc: durin42, kevincox, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel