yuja added a comment.
> +def parentsfunc(index): > + def parentrevs(rev): > + try: > + entry = index[rev] > + except IndexError: > + if rev == wdirrev: > + raise error.WdirUnsupported > + raise > + > + return entry[5], entry[6] > + return parentrevs It doesn't seem correct that the ancestor module handles the revlog's internals. Instead, can't we add a factory function which takes both `index` and `pfunc`? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5443 To: gracinet, indygreg, #hg-reviewers Cc: yuja, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel