yuja added a comment.

  Looks generally good.
  
  Can you add some tests with/without the -T option? There are two callers of
  _showpatch().
  
  > +        graphwidth = props.get('graphwidth')
  >  +        if not graphwidth:
  >  +            graphwidth = 0
  
  Nit: can be written as `props.get('graphwidth', 0)`.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5485

To: navaneeth.suresh, #hg-reviewers
Cc: yuja, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to