On Wed, 06 Feb 2019 14:39:54 +0800, Anton Shestakov wrote:
> # HG changeset patch
> # User Anton Shestakov <a...@dwimlabs.net>
> # Date 1549432950 -28800
> #      Wed Feb 06 14:02:30 2019 +0800
> # Node ID e87cf73bbbffd69efa77b93fa4190d8e0987f339
> # Parent  a5493a251ad3a724b0a7a1bff21248c39611c6de
> revset: add default error messages to getintrange()
> 
> Looks like it's the default values that will vary from one subscript relation
> function to another, but the currently used error messages work for most cases
> (the function is called "getintrange", after all). Let's make it possible to
> reuse these messages.

> -def getintrange(x, err1, err2, deffirst=_notset, deflast=_notset):
> +def getintrange(x, err1=None, err2=None, deffirst=_notset, deflast=_notset):
>      """Get [first, last] integer range (both inclusive) from a parsed tree
>  
>      If any of the sides omitted, and if no default provided, ParseError will
>      be raised.
>      """
> +    if err1 is None:
> +        err1 = _('relation subscript must be an integer or a range')
>      if x and (x[0] == 'string' or x[0] == 'symbol'):
>          n = getinteger(x, err1)
>          return n, n
>      a, b = getrange(x, err1)
> +    if err2 is None:
> +        err2 = _('relation subscript bounds must be integers'),

We'll have to remove "relation subscript" from the default message because
it is the function for parsing arbitrary range values.
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to