taapas1128 added a comment.

  @pulkit I have added some inline comments . So what do you suggest one way 
can be merging this and I will send a follow up for integrating `-n` to `hg 
uncommit`and then amending the tests. The other way is I should send a request 
for `-n` flag and then make all these changes again as a follow up pr for that 
request.

INLINE COMMENTS

> test-uncommit-interactive.t:135
> +
> +  $ hg amend --extract -n "note on amend --extract" -i<<EOF
> +  > y

`hg amend --extract` uses `-n` flag here so it cant be completed with `hg 
uncommit` alone `-n` integration will be necessary. Also `hg obslog` is the 
same test so without this it can also not be replaced.

> test-uncommit-interactive.t:208
> +
> +  $ hg uncommit -n "testing uncommit on dirty wdir" -i<<EOF
> +  > y

Same problem here.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5792

To: taapas1128, #hg-reviewers
Cc: pulkit, lothiraldan, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to