kevincox accepted this revision. kevincox added inline comments. INLINE COMMENTS
> ancestors.rs:245 > self.bases.extend(new_bases); > + self.bases.remove(&NULL_REVISION); > } I think it would be more clear if you filtered the NULL_REVISION out before extending the set. let new_bases = new_bases.into_iter().filter(|&rev| rev != NULL_REVISION); self.bases.extend(new_bases); REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5944 To: gracinet, #hg-reviewers, kevincox Cc: durin42, kevincox, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
