taapas1128 added a comment.

  @martinvonz Sure I will try to unify `_fixdirstate()` and 
`_uncommitdirstate()`. I will follow on the advancements you made. Should I 
send the new patch as a follow up or and altogether new patch making the amends 
in this?

INLINE COMMENTS

> martinvonz wrote in uncommit.py:273
> Unnecessary (done on line 269)

Will look into it.

> martinvonz wrote in uncommit.py:288
> Why did this moved here? I just moved it down in 
> https://phab.mercurial-scm.org/D5660. I really should have written a better 
> commit message explaining what the problem was. But it's also unclear why it 
> should be moved back.

Oh that was a mistake made due to rebasing on top . I will shift that back.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5792

To: taapas1128, #hg-reviewers, durin42
Cc: martinvonz, durin42, pulkit, lothiraldan, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to