yuja added a comment.

  >   def copy(self):
  >       """return an deep copy of the branchcache object"""
  > 
  > - self._verifyall() return type(self)( self._entries, self.tipnode, 
self.tiprev, self.filteredhash, self._closednodes)
  
  Looks good, but it's probably better to copy the verification state to
  new instance, or simply make branchcache() start with "verified" state.
  IIUC, only branches loaded from file have to be validated.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6238

To: pulkit, #hg-reviewers
Cc: yuja, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
[email protected]
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to