indygreg added a comment.
Ideally the new part would be documented in `internals.bundle2`. But other
narrow parts aren't documented, so maybe we can hold off...
INLINE COMMENTS
> narrowbundle2.py:160
>
> +@bundle2.parthandler('Narrowspec')
> +def _handlenarrowspecs(op, inpart):
I don't believe the part name is capitalized in the decorator. Instead, the
part name is capitalized when the part is added to the bundle. Please change
(if necessary) to be consistent with the rest of the world.
> narrowbundle2.py:170
> +
> + if not repository.NARROW_REQUIREMENT in op.repo.requirements:
> + op.repo.requirements.add(repository.NARROW_REQUIREMENT)
Nit: use `if x not in y`.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6310
To: pulkit, durin42, martinvonz, #hg-reviewers
Cc: indygreg, idlsoft, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
