On Sat, 27 Apr 2019 00:25:45 -0400, Gregory Szorc
<gregory.sz...@gmail.com> wrote:
On Fri, Apr 26, 2019 at 9:10 PM Matt Harbison <mharbiso...@gmail.com>
wrote:
# HG changeset patch
# User Matt Harbison <matt_harbi...@yahoo.com>
# Date 1556337169 14400
# Fri Apr 26 23:52:49 2019 -0400
# Branch stable
# Node ID 723ed44028963db5a657578ac358acd07e546daa
# Parent 14589f1989e91a455597cee754ae8587f3725394
inno: bump keyring to 18.0.1 to avoid AttributeError (issue6043)
Queued for stable, thanks.
The Windows packaging code copied what was being done in the wild by
current package maintainers, hence why keyring is present in the Inno
installer but not WiX. We should definitely talk about consolidating
behavior. To what I'm not sure: I'm not sure why various dependencies are
included...
I know I asked the Weeds2000 (who builds the macOS installer for
TortoiseHg) to include this so that mercurial_keyring would work with
`--config extensions.mercurial_keyring=/path/to/repo` type setups. (He
went one further and bundled the extension too.)
It seems that if it isn't installed into the bundled python, it isn't
available to mercurial_keyring at all. I assume that's what's going on
here. I haven't used the WiX installer in an environment where I need
keyring, so IDK if it's broke. I use the thg installer than bundles it
and the extension at work.
(As an aside, I kinda wish we would bundle the extension with the
installer, or even vendor it in hgext3rd. But it sounds like maintaining
it is a bit of a pain.)
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
