pulkit added inline comments.

INLINE COMMENTS

> rdamazio wrote in narrowcommands.py:306
> The difference from the code you're pointing too is that you're calling 
> .result() here, which blocks until the results are fully streamed in (see 
> httppeer.py) - so I really think this is NOT streaming.

1. I see a `.result()` there too 
https://www.mercurial-scm.org/repo/hg-committed/file/127937874395/mercurial/exchange.py#l1751

2. I spent some time understanding whether this is streaming or not, it looks 
like it is not. I will try to understand more the related code path and update 
about my findings.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6436

To: pulkit, durin42, martinvonz, #hg-reviewers
Cc: marmoute, rdamazio, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to