Alphare added a comment.
In D6394#96189 <https://phab.mercurial-scm.org/D6394#96189>, @yuja wrote: >> To my eyes, the point of `Deref` is to make the `struct` act as a "fat pointer" from the outer interface code, but maybe this does not really help that much? > > I feel DirsMultiset isn't a HashMap, but is implemented by using a HashMap. > For example, inner.get().unwrap() returns a refcount of the path, but which > is an implementation detail. > So I think it's better to define methods explicitly instead of proxying > everything to HashMap. I see your point. I'll follow up later today. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6394/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6394 To: Alphare, #hg-reviewers, kevincox Cc: yuja, durin42, kevincox, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
