pulkit added a comment.
> Tests have been shown as test-abort.t There is no such test now. :) INLINE COMMENTS > commands.py:2733 > > +def hgabortgraft(ui, repo, **opts): > + if opts.get('no_backup'): let's move this function to cmdutil.py. Should move _readgraftstate, _abortgraftstate to cmdutil.py too. Movement can be done as a separate patch before this patch. > commands.py:2735 > + if opts.get('no_backup'): > + raise error.Abort(_("graft does not support no-backup flag")) > + if opts.get('dry_run'): `aborting graft ...` > commands.py:2736 > + raise error.Abort(_("graft does not support no-backup flag")) > + if opts.get('dry_run'): > + return 0 We can get rid of this if if we prevent calling abortfunc() in abort command. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6567/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6567 To: taapas1128, #hg-reviewers Cc: pulkit, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel