kevincox added a comment. kevincox accepted this revision.
In D6631#97887 <https://phab.mercurial-scm.org/D6631#97887>, @Alphare wrote: > @kevincox I've renamed the file since it no longer just contains macros. > I've moved whatever I could move to separate structs and used `Cell` instead of `RefCell` on those scalar types. I'm not so keen on using `UnsafeCell`, espacially since the target `py_class!`-resulting struct could be using `RefCell`-specific APIs. Ack. it still feels like we are kinda implementing a second `RefCell` anyways but I think this code is quite clean. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6631/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6631 To: Alphare, #hg-reviewers, kevincox Cc: gracinet, durin42, kevincox, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
