kevincox added inline comments.
kevincox accepted this revision.
INLINE COMMENTS
> utils.rs:44
> fn trim(&self) -> &Self;
> + fn chop_prefix(&self, needle:&Self) -> Option<&Self>;
> }
I have a small preference for `drop_prefix`.
> utils.rs:44
> fn trim(&self) -> &Self;
> + fn chop_prefix(&self, needle:&Self) -> Option<&Self>;
> }
Put a space in `needle: &Self`
> utils.rs:86
> +
> + fn chop_prefix(&self, needle:&Self) -> Option<&Self> {
> + if self.starts_with(needle) {
Put a space in needle: &Self
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6766/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6766
To: valentin.gatienbaron, #hg-reviewers, kevincox
Cc: durin42, kevincox, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
