martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers.
REVISION SUMMARY The "opts" are already converted to bytes at the beginning of the function. Doing it twice results in a crash, which makes test-uncommit.t fail. The extra call was added recently, in ff1ff2aae132 <https://phab.mercurial-scm.org/rHGff1ff2aae132ba74687460df075acf32af427ac7> (uncommit: add support to modify the commit message and date, 2019-09-07). test-uncommit.t passes again after this patch. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6864 AFFECTED FILES hgext/uncommit.py CHANGE DETAILS diff --git a/hgext/uncommit.py b/hgext/uncommit.py --- a/hgext/uncommit.py +++ b/hgext/uncommit.py @@ -177,7 +177,7 @@ with repo.transaction('uncommit'): if not (opts[b'message'] or opts[b'logfile']): opts[b'message'] = old.description() - message = cmdutil.logmessage(ui, pycompat.byteskwargs(opts)) + message = cmdutil.logmessage(ui, opts) keepcommit = pats if not keepcommit: To: martinvonz, #hg-reviewers Cc: mercurial-devel _______________________________________________ Mercurial-devel mailing list [email protected] https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
