Kwan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers.
REVISION SUMMARY While arcanist does this I could see us leaving it out for a couple reasons: 1. arcanist only operates on the current stack, so can use the actual active bookmark, whereas phabsend works with any commits, so if there are multiple bookmarks it'll just pick the first one arbitrarily 2. some users might not like the disclosure REPOSITORY rHG Mercurial BRANCH creatediff (bookmark) on default (branch) REVISION DETAIL https://phab.mercurial-scm.org/D7056 AFFECTED FILES hgext/phabricator.py CHANGE DETAILS diff --git a/hgext/phabricator.py b/hgext/phabricator.py --- a/hgext/phabricator.py +++ b/hgext/phabricator.py @@ -829,9 +829,11 @@ repo = ctx.repo() repophid = getrepophid(repo) # Create a "Differential Diff" via "differential.creatediff" API + bookmark = ctx.bookmarks()[0] if ctx.bookmarks() else None pdiff = phabdiff( sourceControlBaseRevision=b'%s' % ctx.p1().hex(), branch=b'%s' % ctx.branch(), + bookmark=bookmark, ) modified, added, removed, _d, _u, _i, _c = ctx.p1().status(ctx) # addadded will remove moved files from removed, so addremoved won't get To: Kwan, #hg-reviewers Cc: mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
