martinvonz added a comment.

  Looks good to me, but I don't know Python well enough to say if 
`mercurial.help` and `mercurial.help.internal` should be "namespace packages" 
(which I think is what you're doing with the `pkgutil.extend_path()` stuff). 
I'd appreciate it if someone who knows Python better can comment.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7376/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7376

To: mharbison72, #hg-reviewers
Cc: martinvonz, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to