This revision now requires changes to proceed.
dlax added inline comments.
dlax requested changes to this revision.
INLINE COMMENTS
> pycompat.py:294
>
> + bytestr = _bytestr # type: Callable[[Union[bytes, str], bytestr]
> +
A `]` is missing before `, bytestr`. Then, it's also missing `typing` imports.
But, even with this, I get:
Invalid type comment: Callable[[Union[bytes, str]], bytestr]
[invalid-type-comment]
Name 'bytestr' is not defined
I'm able to make this pass with:
bytestr = _bytestr
bytestr = bytestr # type: Callable[[Union[bytes, str]], bytestr]
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7296/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7296
To: durin42, #hg-reviewers, indygreg, dlax
Cc: mjpieters, dlax, indygreg, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
