This revision now requires changes to proceed. dlax added a comment. dlax requested changes to this revision.
nit: the actual PEP is pep-0461 (https://www.python.org/dev/peps/pep-0461/) INLINE COMMENTS > localrepo.py:1571 > + b"unsupported changeid '%r' of type %r" > % (changeid, pycompat.sysstr(type(changeid))) > ) The first `%s` was correct I think because `changeid` can be a bytes. For the second one, if `%r` is the way to go (I'm not sure), maybe we can drop `pycompat.sysstr()`? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7504/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7504 To: matclab, #hg-reviewers, dlax Cc: dlax, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
