mharbison72 added a comment.

  In D7506#110351 <https://phab.mercurial-scm.org/D7506#110351>, @dlax wrote:
  
  > The revisions shown by the "phabstatus" view is just a subset of that of 
"work" view (subset of revisions with a differential). Do you see more 
revisions in "phabstatus" than in "work" or am I misunderstanding something?
  
  No, there are 89 entries in work, and 35 in phabstatus.  (I used `../hg show 
phabstatus | egrep '[0-9a-f]{6}' | wc -l` to tame the output.)  My confusion 
was that things that are direct descendants were showing like they were all 
separate heads.  (e.g. the revision marked `@` and the `@` bookmark 3 above it 
in phabstatus //should// be a direct line.)  This latest update made things 
look way more sane.  The remaining old junk in my output is likely because I 
tend to leave anonymous branches laying around, and it's adding upstream 
parents for context.
  
  > Or perhaps this is because of a wrong sorting of the filtered set? I'll 
make sure the final is still topo sorted and send another version in a moment.
  >
  >> Is the goal to limit to the current stack, or all non public commits?  I 
can see a use case for both.
  >
  > I don't use the "stack" view often, so my goal is to map to the "work" view 
which I use more. But perhaps it'd make sense to have "hg show phabwork" and 
"hg show phabstack"? (We can rename the view, and add the other one later on.)
  
  I had forgotten about the extension TBH.  Because I tend to leave junk 
around, I'd probably use the stack view much more.  Narrowing to the stack also 
seems useful now that the author has been removed since the first revision of 
this.  So I think having both is a good idea.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7506/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7506

To: dlax, #hg-reviewers
Cc: mharbison72, mjpieters, Kwan, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to