martinvonz added inline comments. INLINE COMMENTS
> martinvonz wrote in matchers.rs:166 > How about we just replace the implementation by > `VisitChildrenSet::Recursive`then? That's easy to maintain and makes it > functionally correct. It's usually fast enough too. Alphare pointed out to me out of band that the Python code already does the same, so I agree that it makes sense to just copy that for now. I'm sorry that I didn't think of checking that before. It would have been even better to fix the Python version first and then copy the good code to Rust, but I'm still fine with doing that later. PS. I haven't actually reviewed this code. I'll do that next week (and Monday is a holiday for me). REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7914/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7914 To: Alphare, #hg-reviewers Cc: martinvonz, durin42, kevincox, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
