martinvonz added inline comments.

INLINE COMMENTS

> pulkit wrote in cmdutil.py:1698
> generally we refer to `repo[None]` as `wctx` right?

I didn't do that because I had planned the next patch, where the same code is 
used for working copy and not, so `ctx` isn't necessarily the working copy.

> pulkit wrote in commands.py:7502
> We should add descriptive function documentation which will be visible to 
> user when they do `hg uncopy -h`.

Oops, I just forgot about that, I think. I'll send a follow-up (I assume you 
know that many of the patches you're reviewing now are already queued).

REPOSITORY
  rHG Mercurial

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8029/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8029

To: martinvonz, #hg-reviewers, durin42
Cc: pulkit, durin42, marmoute, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to