dlax added a comment.
In D7384#118739 <https://phab.mercurial-scm.org/D7384#118739>, @marmoute wrote: > What's up on this ? It seemed on a good track, but I don't think it landed. @dlax I think you offer to use a context manager got a warm welcome, I would says, go ahead with it. The context manager got in through D7430 <https://phab.mercurial-scm.org/D7430>. INLINE COMMENTS > commands.py:4741 > + # pytype isn't convinced, so we have to suppress the > + # warning about list not having a max() method. > endrev = revs.max() + 1 I think this comment should be removed since the `# pytype: disable` got removed in the last version of the diff. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7384/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7384 To: durin42, #hg-reviewers, dlax Cc: marmoute, dlax, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
