marmoute added inline comments. INLINE COMMENTS
> martinvonz wrote in nodemap.py:49 > and here? this is a series that introduced a lot of new code, so try running > all (previously passing) py3 test at least at the end of the series If you can taje the series starting at D8011 <https://phab.mercurial-scm.org/D8011>, if would help me to make sure all angles are covered. > martinvonz wrote in nodemap.py:50-51 > Actually, does `revlog.opener.write(revlog.nodemap_file, data)` work? probably, but we will need the context manager approach later in the series so I don't think it is worth updating. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7835/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7835 To: marmoute, indygreg, #hg-reviewers Cc: martinvonz, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel