mharbison72 added inline comments. mharbison72 requested review of this revision.
INLINE COMMENTS > marmoute wrote in test-clonebundles.t:458-464 > Your patch is about testing error when only one of the items is bad. Then, > your tests only test it with a single item. Am I missing something or should > we have a tests with multiple items in the list ? Not sure I understand. There are a handful of tests in test-clonebundles.t that have multiple key/value pairs already, so the good case is covered. (I missed this before and thought that I commented there was no coverage, but I was wrong and don't see that comment now.) The setting needs to be in `ui.clonebundles=key=value[,key=value]` form. So if it catches a single malformed key/value pair, I'm not sure that it buys us anything to have a `good,bad` test too, unless I'm missing something. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7969/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7969 To: mharbison72, #hg-reviewers, marmoute Cc: marmoute, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
