Alphare added inline comments. INLINE COMMENTS
> kevincox wrote in status.rs:76 > It would be more clear to do `.sort_by_key(|e| e.0)` > > And I don't think stability matters here so you could use > `sort_unstable_by_key`. I didn't realize that `sort_unstable_by_key` needed to return a `T` and not a `&T`, that forces a `clone()`. I'm not sure that matters, we'll go with the shortest code and see if that shows up in profiling later. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7927/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7927 To: Alphare, #hg-reviewers, marmoute, kevincox Cc: marmoute, durin42, kevincox, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
