martinvonz added a comment.

  In D8030#120771 <https://phab.mercurial-scm.org/D8030#120771>, @marmoute 
wrote:
  
  > I had a longer discussion with @martinvonz on IRC on about this feature, he 
also pointed out to  D7631 <https://phab.mercurial-scm.org/D7631> doing similar 
work for `hg absorb`.
  > From that discussion I understand there is a wider objective for many 
mercurial commands to gain the ability to use a specific revision in place of 
the working copy. (eg: hg amend, hg aborb, hg copy, etc…)
  > The idea is quite interresting and can unlock powerfull capabilities. 
However, this is a rather big UX project, I think we need a step back and think 
about this idea on a large scale. I am thinking at least a Plan page with a 
wider study of the command that could be impacted how the UI will be 
consistent. This allows a wider set of the community to chim in on  such a big 
project.
  > A concret issue I current have with the plan is the planned `--rev` flag 
usage. To me, and other people around me, something like `hg amend --rev X` 
would means "amend change from the working copy into revision `X`". likewise 
`hg absorb --rev REVSET` would absorb the working copy change into the `REVSET` 
set  of revisions. So the use of `--rev` is surprising to some and should be 
discussed. Maybe the `--change` flag (used, but `hg status` and `hg diff`) 
would be more suitable? Maybe a global flag --change-as-wdir that would work 
for any commands ?
  > This is the kind of question I would like to see discussed more widely 
before we invest more in this idea (Idea, that I find interresting overall). I 
added this as a topic for the upcoming sprint.
  > (Sorry for the delay this will involves, I wish the idea had explicitly 
surfaced earlier).
  
  I'm fine with marking the use of `-r` experimental. I don't like the idea of 
delaying this feature two months. Any problem with marking it experimental for 
now? As usual with experimental features, that will allow us to rename the flag 
(and change other behavior) before we take it out of experimental.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8030/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8030

To: martinvonz, #hg-reviewers, durin42, marmoute
Cc: marmoute, pulkit, durin42, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to