martinvonz added a comment.
In D8254#123111 <https://phab.mercurial-scm.org/D8254#123111>, @marmoute wrote: > In D8254#123110 <https://phab.mercurial-scm.org/D8254#123110>, @martinvonz wrote: > >> In D8254#123109 <https://phab.mercurial-scm.org/D8254#123109>, @marmoute wrote: >> >>> In D8254#122981 <https://phab.mercurial-scm.org/D8254#122981>, @martinvonz wrote: >>> >>>> In D8254#122978 <https://phab.mercurial-scm.org/D8254#122978>, @marmoute wrote: >>>> >>>>> Good catch, look good to me. Can we drop the `skip-blame just adding a missing r-prefix` inflight? >>>> >>>> 563dfdfd01a4 <https://phab.mercurial-scm.org/rHG563dfdfd01a4e050b5ea01796843cf2fd2d33ef9> is public, so no? >>> >>> I am confused, because this diff was not even landed. when you commented this. >> >> Note that my comment was not talking about this patch but about the commit that introduced bad regex. >> Anyway, I think I misunderstood your original comment because I didn't see the quotes in it, so I thought you were asking reviewers to add the missing r'' prefix in flight. > > Haa, I understand the misunderstanding now. Now that things are clearer, Can we fix the queued changeset ? Yes, I agree with removing it since this is a bug-fix (not a py3 compat thing). I'll do that. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8254/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8254 To: durin42, #hg-reviewers, marmoute, pulkit Cc: martinvonz, marmoute, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
