martinvonz added inline comments.
INLINE COMMENTS
> __init__.py:89-94
> + reqsf = os.path.join(storebasepath, b'requires')
> + reqs = set()
> + if os.path.exists(reqsf):
> + with open(reqsf, 'rb') as f:
> + reqs = {l.strip() for l in f}
> + if b'git' in reqs:
is this different from `if b'git' in requirements`?
> test-git-interop.t:5-11
> > GIT_AUTHOR_EMAIL='t...@example.org'; export GIT_AUTHOR_EMAIL
> > GIT_AUTHOR_DATE="2007-01-01 00:00:00 +0000"; export GIT_AUTHOR_DATE
> > GIT_COMMITTER_NAME="$GIT_AUTHOR_NAME"; export GIT_COMMITTER_NAME
> > GIT_COMMITTER_EMAIL="$GIT_AUTHOR_EMAIL"; export GIT_COMMITTER_EMAIL
> > GIT_COMMITTER_DATE="$GIT_AUTHOR_DATE"; export GIT_COMMITTER_DATE
> -
> > count=10
> > gitcommit() {
`$` prefix on these too since you're cleaning up anyway?
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D8265/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D8265
To: durin42, #hg-reviewers
Cc: pulkit, martinvonz, mharbison72, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
