marmoute added a comment.
In D8189#123521 <https://phab.mercurial-scm.org/D8189#123521>, @mharbison72 wrote: > In D8189#123323 <https://phab.mercurial-scm.org/D8189#123323>, @durin42 wrote: > >> I think it might be better to poll more often in the script and not even take a timeout: sleep forever waiting for the condition, and if it never comes let the test timeout at the runner level. Thoughts? > > I filed a bug about this that self-archived, but: > > $ echo ' $ sleep 10' > test-timeout.t > $ time ./run-tests.py --local test-timeout.t -t 5 > running 1 tests using 1 parallel processes > t > Failed test-timeout.t: timed out > # Ran 1 tests, 0 skipped, 1 failed. > python hash seed: 204038743 > real 0m10.363s > user 0m0.000s > sys 0m0.030s > > So it looks like tests never timeout, but then the result is discarded afterward if the timeout period elapsed. I can reproduce it on Windows and macOS. Do you have a link to the bug ? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8189/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8189 To: marmoute, #hg-reviewers Cc: mharbison72, durin42, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
