mharbison72 added inline comments.
mharbison72 accepted this revision.

INLINE COMMENTS

> martinvonz wrote in test-push-race.t:1-3
> > Please avoir putting content before the
> > test file title.
> 
> Why? (I personally don't find this hard to read.)

I'd go further and say it's easier to read when `#testcases` is the very first 
line, as it doesn't get visually swallowed by nesting between two long lines.  
(I didn't realize they didn't have to be the first line, and wouldn't have 
looked anywhere else either.)

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8282/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8282

To: martinvonz, durin42, #hg-reviewers, marmoute, mharbison72
Cc: mharbison72, marmoute, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to