spectral added a comment.
In D8281#124247 <https://phab.mercurial-scm.org/D8281#124247>, @martinvonz wrote: > In D8281#124246 <https://phab.mercurial-scm.org/D8281#124246>, @spectral wrote: > >> - Server emits a new capability `narrow-exp-1-escaped` (in addition to the current `narrow-exp-1`, this is not replacing the existing capability) > > nit: I *think* the "1" in the name was supposed to be a version number, so the new capability's name would be `narrow-exp-2`. Yes, I had assumed that as well. This isn't really a new version of the protocol, though, just a minor tweak, and it's primarily to the 'csv' type used in getbundle (see the current version of this patch that adds 'qcsv' for the actual locations it's used). Honestly I went back and forth between announcing it as `getbundle-csv-escaped` and something related to narrow (and ended up on narrow, as you see, since while it's generically useful besides narrow, nothing else needs it today, and future things wouldn't need this to be announced forever - they'll always have used foo.escaped and been transmitted as escaped). > Maybe no one uses the "widen" command so we don't even need to worry about compatibility there? I don't know how often it's used :) I just know that there's something *not* getbundle-related in narrowwirepeer.py (looks like it's called `narrow_widen` that needed to be modified or else the tests wouldn't pass. I honestly don't even know if we're using it internally at Google right now. If not, that's fewer things to change, which I'm OK with :) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8281/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8281 To: spectral, durin42, martinvonz, #hg-reviewers, marmoute Cc: marmoute, mharbison72, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
