mharbison72 added a comment.
In D8337#124542 <https://phab.mercurial-scm.org/D8337#124542>, @yuja wrote: > On Windows, my assumption was os.fsencode() == .encode("mbcs") if > sys._enablelegacywindowsfsencoding(). So this looks good to me. > Perhaps, the "ignore" error mode would match the legacy Windows behavior. Does this mean it could be a problem running from source on Windows? For example, `hg version` (as opposed to `hg.exe version`) seems to be equivalent to `python hg`, which obviously doesn't have the proper environment variable or C API option to enable legacy mode. Should there be code early on that detects this and warns/aborts? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8337/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8337 To: indygreg, #hg-reviewers Cc: mharbison72, yuja, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
