marmoute added a comment.
marmoute accepted this revision.
Seems overall good. I have some fear over the `sleep` usage, butit does not
seems to depends on test, and I don't know what antivirus looks like.
INLINE COMMENTS
> debugcommands.py:143
> + # Give an AV engine time to scan the file.
> + time.sleep(2)
> + util.unlink(repo.cachevfs.join('eicar-test-file.com'))
That seems short ? that might fails on heavy load system. Also, this confused
me a bit. How is the antivirus failure supposed to manifest when this code is
run? I have no experience with them.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D8353/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D8353
To: durin42, #hg-reviewers, marmoute
Cc: mercurial-patches, marmoute, mharbison72, indygreg, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
