mharbison72 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches.
REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D9205 AFFECTED FILES mercurial/posix.py CHANGE DETAILS diff --git a/mercurial/posix.py b/mercurial/posix.py --- a/mercurial/posix.py +++ b/mercurial/posix.py @@ -144,26 +144,24 @@ if l: if not stat.S_ISLNK(s): # switch file to link - fp = open(f, b'rb') - data = fp.read() - fp.close() + with open(f, b'rb') as fp: + data = fp.read() unlink(f) try: os.symlink(data, f) except OSError: # failed to make a link, rewrite file - fp = open(f, b"wb") - fp.write(data) - fp.close() + with open(f, b"wb") as fp: + fp.write(data) + # no chmod needed at this point return if stat.S_ISLNK(s): # switch link to file data = os.readlink(f) unlink(f) - fp = open(f, b"wb") - fp.write(data) - fp.close() + with open(f, b"wb") as fp: + fp.write(data) s = 0o666 & ~umask # avoid restatting for chmod sx = s & 0o100 To: mharbison72, #hg-reviewers Cc: mercurial-patches, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
