Mesa (master): mesa: do scope replacement for while/for loops too

[Brian Paul]

Module: Mesa
Branch: master
Commit: b625a0a47524de1b2968f9bf6a23ae0102726b5a
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=b625a0a47524de1b2968f9bf6a23ae0102726b5a

Author: Brian Paul <[EMAIL PROTECTED]>
Date:   Sat Nov  1 15:55:39 2008 -0600

mesa: do scope replacement for while/for loops too

This fixes a function inlining bug involving vars declared inside loop bodies.

---

 src/mesa/shader/slang/slang_compile_operation.c |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/src/mesa/shader/slang/slang_compile_operation.c 
b/src/mesa/shader/slang/slang_compile_operation.c
index 1002be1..53cf6fa 100644
--- a/src/mesa/shader/slang/slang_compile_operation.c
+++ b/src/mesa/shader/slang/slang_compile_operation.c
@@ -80,21 +80,23 @@ slang_replace_scope(slang_operation *oper,
                     slang_variable_scope *newScope)
 {
    GLuint i;
+
    if (oper->locals != newScope &&
        oper->locals->outer_scope == oldScope) {
+      /* found.  replace old w/ new */
       oper->locals->outer_scope = newScope;
    }
 
    if (oper->type == SLANG_OPER_VARIABLE_DECL) {
+      /* search/replace in the initializer */
       slang_variable *var;
       var = _slang_locate_variable(oper->locals, oper->a_id, GL_TRUE);
       if (var && var->initializer) {
-         printf("replace scope for %s initializer\n",
-                (char *) var->a_name);
          slang_replace_scope(var->initializer, oldScope, newScope);
       }
    }
 
+   /* search/replace in children */
    for (i = 0; i < oper->num_children; i++) {
       slang_replace_scope(&oper->children[i], oldScope, newScope);
    }
@@ -159,7 +161,9 @@ slang_operation_copy(slang_operation * x, const 
slang_operation * y)
    /* If this operation declares a new scope, we need to make sure
     * all children point to it, not the original operation's scope!
     */
-   if (x->type == SLANG_OPER_BLOCK_NEW_SCOPE) {
+   if (x->type == SLANG_OPER_BLOCK_NEW_SCOPE ||
+       x->type == SLANG_OPER_WHILE ||
+       x->type == SLANG_OPER_FOR) {
       slang_replace_scope(x, y->locals, x->locals);
    }
 

_______________________________________________
mesa-commit mailing list
mesa-commit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-commit