Module: Mesa Branch: master Commit: a575bb136973901bdbe7478c77aa5a0ad5d7464d URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a575bb136973901bdbe7478c77aa5a0ad5d7464d
Author: Vinson Lee <[email protected]> Date: Wed Oct 21 16:09:27 2020 -0700 draw: Remove draw_install_aaline_stage dead code. Remove dead code left over from commit dbb2cf388b79 ("draw: simplify (and correct) aaline fallback (v2)"). Fix defect reported by Coverity Scan. Logically dead code (DEADCODE) dead_error_line: Execution cannot reach this statement: (*aaline->stage.destroy)(&a.... Signed-off-by: Vinson Lee <[email protected]> Reviewed-by: Ian Romanick <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7265> --- src/gallium/auxiliary/draw/draw_pipe_aaline.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/gallium/auxiliary/draw/draw_pipe_aaline.c b/src/gallium/auxiliary/draw/draw_pipe_aaline.c index d380b4295d4..de6f970fe4b 100644 --- a/src/gallium/auxiliary/draw/draw_pipe_aaline.c +++ b/src/gallium/auxiliary/draw/draw_pipe_aaline.c @@ -747,7 +747,7 @@ draw_install_aaline_stage(struct draw_context *draw, struct pipe_context *pipe) */ aaline = draw_aaline_stage(draw); if (!aaline) - goto fail; + return FALSE; /* save original driver functions */ aaline->driver_create_fs_state = pipe->create_fs_state; @@ -764,10 +764,4 @@ draw_install_aaline_stage(struct draw_context *draw, struct pipe_context *pipe) draw->pipeline.aaline = &aaline->stage; return TRUE; - -fail: - if (aaline) - aaline->stage.destroy(&aaline->stage); - - return FALSE; } _______________________________________________ mesa-commit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-commit
