Module: Mesa
Branch: master
Commit: 98b2aacfbfe3cbdeabed3200b98cb02915d08b29
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=98b2aacfbfe3cbdeabed3200b98cb02915d08b29

Author: Marek Olšák <[email protected]>
Date:   Sat Nov 14 16:27:05 2020 -0500

radeonsi: remove unnecessary NULL checking in NIR tess functions

param_index is always checked for non-NULL later.

Acked-by: Pierre-Eric Pelloux-Prayer <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7623>

---

 src/gallium/drivers/radeonsi/si_shader_llvm_tess.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/src/gallium/drivers/radeonsi/si_shader_llvm_tess.c 
b/src/gallium/drivers/radeonsi/si_shader_llvm_tess.c
index bedab127e1a..3f081a2c65a 100644
--- a/src/gallium/drivers/radeonsi/si_shader_llvm_tess.c
+++ b/src/gallium/drivers/radeonsi/si_shader_llvm_tess.c
@@ -412,10 +412,6 @@ static LLVMValueRef si_nir_load_tcs_varyings(struct 
ac_shader_abi *abi, LLVMType
       }
    }
 
-   if (!param_index) {
-      param_index = ctx->ac.i32_0;
-   }
-
    dw_addr = get_dw_address_from_generic_indices(ctx, stride, dw_addr, 
vertex_index, param_index,
                                                  semantic);
 
@@ -444,10 +440,6 @@ static LLVMValueRef si_nir_load_input_tes(struct 
ac_shader_abi *abi, LLVMTypeRef
 
    base = ac_get_arg(&ctx->ac, ctx->tcs_offchip_offset);
 
-   if (!param_index) {
-      param_index = ctx->ac.i32_0;
-   }
-
    addr =
       get_tcs_tes_buffer_address_from_generic_indices(ctx, vertex_index, 
param_index, semantic);
 
@@ -476,10 +468,7 @@ static void si_nir_store_output_tcs(struct ac_shader_abi 
*abi,
 
    ubyte semantic = info->output_semantic[driver_location];
 
-   bool is_const = !param_index;
-   if (!param_index)
-      param_index = ctx->ac.i32_0;
-
+   const bool is_const = !param_index;
    const bool is_patch = vertex_index == NULL;
 
    /* Invalid SPIR-V can cause this. */

_______________________________________________
mesa-commit mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-commit

Reply via email to